Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min libc message in distribution release notes #1059

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Fix min libc message in distribution release notes #1059

merged 1 commit into from
Jul 13, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 13, 2023 •
edited
Loading

Content

This PR fix the glibc linux requirements block in distribution release note, all text that were enclosed in back-ticks were discarded (see last unstable release).

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #874

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited
Loading

Test Results

    3 files  ±0    16 suites  ±0   6m 5s ⏱️ -15s
635 tests ±0  635 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
673 runs  ±0  673 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0897300. ± Comparison against base commit 1798536.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview July 13, 2023 12:37 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/874/fix_min_libc_version_in_release_description branch from 1e82684 to 0897300 Compare July 13, 2023 13:06
jpraynaud
jpraynaud approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar temporarily deployed to testing-preview July 13, 2023 13:16 — with GitHub Actions Inactive
@Alenar Alenar merged commit 26d4bf6 into main Jul 13, 2023
24 checks passed
@Alenar Alenar deleted the djo/874/fix_min_libc_version_in_release_description branch July 13, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alenar @jpraynaud